Rigorous and Reliable (RAR)

(09-03-2020 11:53 PM)lingu Wrote: [ -> ]insert (){
# if "type":"insert"
casetype=`jq '.type' $newcasepfn`
if [[ $casetype == "\"insert\"" ]]; then
newdir=$(ls /thinker/globe/udata/lingu/testy/procuratorate/tests/typical | wc -l)

such logic is quite error-prone because w dont know who may write something to the dir 'typical'.

I suggest we change it to use casecnt.

Quote: mkdir $newdir
casecnt=$((++newdir))

no need to do ++ here and the assignment because the code above already handles both.

RR zhihao

--- working practively, I have implemented the above in cod://yotta commit fae4fb1

I am deleting the trash cases 11-200.

save a copy first.

Remove trash files.

Adjust the value of bibo_doc_cnt.

(09-03-2020 11:53 PM)lingu Wrote: [ -> ]talk2thinker.sh

Code:

读取一个案例请求，保存到$toneroot/newreeq文件,执行tellThinker, getresults函数
...
...
  /bin/cp $reqpfn $newcasepfn
  flog_enable_timestamp=True flog "    received new case in $newcasepfn"

insert (){
  # if "type":"insert"
  casetype=`jq '.type' $newcasepfn`
  if [[ $casetype == "\"insert\"" ]]; then
    newdir=$(ls /thinker/globe/udata/lingu/testy/procuratorate/tests/typical | wc -l)
    mkdir $newdir
    casecnt=$((++newdir))
    cp $newcasepfn $newdir/insert.json

    echo -e "{\n\
    "code": 200,\n\
    "msg": "ok",\n\
    "children": []\n\
    }"
    exit 0
  fi
}

修改首文talk2thinker.sh的伪代码部分为：

RR lingu

(09-22-2020 09:56 PM)lingu Wrote: [ -> ]

(09-03-2020 11:53 PM)lingu Wrote: [ -> ]insert (){
# if "type":"insert"
casetype=`jq '.type' $newcasepfn`
if [[ $casetype == "\"insert\"" ]]; then
newdir=$(ls /thinker/globe/udata/lingu/testy/procuratorate/tests/typical | wc -l)

such logic is quite error-prone because w dont know who may write something to the dir 'typical'.

I suggest we change it to use casecnt.

Code:

newdir=/thinker/globe/udata/lingu/testy/procuratorate/tests/typical/$((++casecnt))

Quote: mkdir $newdir
casecnt=$((++newdir))

no need to do ++ here and the assignment because the code above already handles both.

RR zhihao

--- working practively, I have implemented the above in cod://yotta commit fae4fb1

LGTM

(09-22-2020 09:41 PM)lingu Wrote: [ -> ]driver: we need handle case count well for the bibo system.

(09-03-2020 11:53 PM)lingu Wrote: [ -> ]talk2thinker.sh

读取一个案例请求，保存到$toneroot/newreeq文件,执行tellThinker, getresults函数
...
...

If we have vars in bibo-ext.pcf -- http://rar.shufangkeji.com:60380/showthr...4#pid43444 I suggest we read case count here.

Code:

casecnt = use the pcf program to read bibo_doc_cnt in $bibo_base/bibo-ext.pcf

Quote:
/bin/cp $reqpfn $newcasepfn
flog_enable_timestamp=True flog " received new case in $newcasepfn"

insert (){
# if "type":"insert"
casetype=`jq '.type' $newcasepfn`
if [[ $casetype == "\"insert\"" ]]; then
newdir=$(ls /thinker/globe/udata/lingu/testy/procuratorate/tests/typical | wc -l)
mkdir $newdir
casecnt=$((++newdir))

We need update the case count here.

Code:

use the pcf program to write bibo_doc_cnt as casecnt in $bibo_base/bibo-ext.pcf

RR zhihao

--- working proactively. I added the logic in cod://prada commit 7b8c391

A simple test of pcf shows the functionality of pcf works as expected.

Code:

20:35:08 lingu@g1b-2:/home/lingu/forest/prada/prada> pcf --pcf /thinker/globe/soft/bibo/bibo-ext.pcf --get bibo_doc_cnt
10
20:49:09 lingu@g1b-2:/home/lingu/forest/prada/prada> pcf --pcf /thinker/globe/soft/bibo/bibo-ext.pcf --add bibo_doc_cnt 11
20:49:27 lingu@g1b-2:/home/lingu/forest/prada/prada> pcf --pcf /thinker/globe/soft/bibo/bibo-ext.pcf --get bibo_doc_cnt
11
20:49:29 lingu@g1b-2:/home/lingu/forest/prada/prada>

LGTM

(09-23-2020 12:39 AM)zhihao Wrote: [ -> ]

(09-03-2020 11:53 PM)lingu Wrote: [ -> ]talk2thinker.sh

Code:

读取一个案例请求，保存到$toneroot/newreeq文件,执行tellThinker, getresults函数
...
...
  /bin/cp $reqpfn $newcasepfn
  flog_enable_timestamp=True flog "    received new case in $newcasepfn"

insert (){
  # if "type":"insert"
  casetype=`jq '.type' $newcasepfn`
  if [[ $casetype == "\"insert\"" ]]; then
    newdir=$(ls /thinker/globe/udata/lingu/testy/procuratorate/tests/typical | wc -l)
    mkdir $newdir
    casecnt=$((++newdir))
    cp $newcasepfn $newdir/insert.json

    echo -e "{\n\
    "code": 200,\n\
    "msg": "ok",\n\
    "children": []\n\
    }"
    exit 0
  fi
}

修改首文talk2thinker.sh的伪代码部分为：

function work; do
while $newcasepfn is not null; do
read $newcasepfn
done

You need define that is 'not full'. Otherwise, we cannot translate this pseudocode into code scientifically.

Quote: funtion tellThinker; do
set $casecnt as the number of cases
create a new directory $newdir, set its name as $casecnt + 1
copy $newcasepfn to $newdir

for each case; do
analyse cases with sage
done
done

OK but pls use a separate code block for a function, unless the function is nested in another.

I also suggest you use C-style syntactic structures, such as

The C-style representation is usually more concise.

Quote: function getresults; do
function scrutinize:
generate response for each case
generate response for all cases
return response
done
done
[/code]

RR lingu

I think they are generally better than before. So I am fine with the updates.

(09-23-2020 01:08 AM)lingu Wrote: [ -> ]

(09-23-2020 12:39 AM)zhihao Wrote: [ -> ]

(09-03-2020 11:53 PM)lingu Wrote: [ -> ]talk2thinker.sh

Code:

读取一个案例请求，保存到$toneroot/newreeq文件,执行tellThinker, getresults函数
...
...
  /bin/cp $reqpfn $newcasepfn
  flog_enable_timestamp=True flog "    received new case in $newcasepfn"

insert (){
  # if "type":"insert"
  casetype=`jq '.type' $newcasepfn`
  if [[ $casetype == "\"insert\"" ]]; then
    newdir=$(ls /thinker/globe/udata/lingu/testy/procuratorate/tests/typical | wc -l)
    mkdir $newdir
    casecnt=$((++newdir))
    cp $newcasepfn $newdir/insert.json

    echo -e "{\n\
    "code": 200,\n\
    "msg": "ok",\n\
    "children": []\n\
    }"
    exit 0
  fi
}

修改首文talk2thinker.sh的伪代码部分为：

function work; do
while $newcasepfn is not null; do
read $newcasepfn
done

You need define that is 'not full'. Otherwise, we cannot translate this pseudocode into code scientifically.

while循环已修改为 read $newcasepfn till meet blank line

(09-23-2020 01:08 AM)lingu Wrote: [ -> ]

Quote: funtion tellThinker; do
set $casecnt as the number of cases
create a new directory $newdir, set its name as $casecnt + 1
copy $newcasepfn to $newdir

for each case; do
analyse cases with sage
done
done

OK but pls use a separate code block for a function, unless the function is nested in another.

I also suggest you use C-style syntactic structures, such as

Code:

tellThinker() {
        set $casecnt as the number of cases
        create a new directory $newdir, set its name as $casecnt + 1
        copy $newcasepfn to $newdir
        
        for each case {
            analyse cases with sage
        }
}

The C-style representation is usually more concise.

work内的函数已提取到代码块外面。
函数现已使用C结构表示。
伪代码如下：

(09-23-2020 01:08 AM)lingu Wrote: [ -> ]

Quote: function getresults; do
function scrutinize:
generate response for each case
generate response for all cases
return response
done
done
[/code]

RR lingu

I think they are generally better than before. So I am fine with the updates.

已更新首文talk2thinker.sh伪代码

(09-23-2020 11:34 AM)zhihao Wrote: [ -> ]not null 已修改为 not full。work内的函数已提取到代码块外面。函数现已使用C结构表示。
已更新首文。

I have split the blocks of functions in the headpost, and added an explanation line to the functions. This will make the writing easier to read.

Quote:tellThinker() {
set $casecnt as the number of cases
create a new directory $newdir, set its name as $casecnt + 1
copy $newcasepfn to $newdir

for each case; do
analyse cases with sage
done
}

This logic needs to handle multiple types of requests -- query, insert, delete. Pls design the switching logic and use different functions to do the work.

Also, design and implement the delete logic as we discussed -- for delete, rename the original file to be a different name, create a file in the original name and make sure it does not match any keywords.

Later, we need move the logic to a C++ program so that it can communicate with think in memory-to-memory data exchange.

(09-03-2020 11:53 PM)lingu Wrote: [ -> ]procone.py

Code:

在某一案例内容中搜索key{1,2,3}，构建"keys": []。

添加procone.py 伪代码，增加删除功能

RR lingu

(09-23-2020 12:14 PM)lingu Wrote: [ -> ]

Quote:tellThinker() {
set $casecnt as the number of cases
create a new directory $newdir, set its name as $casecnt + 1
copy $newcasepfn to $newdir

for each case; do
analyse cases with sage
done
}

This logic needs to handle multiple types of requests -- query, insert, delete. Pls design the switching logic and use different functions to do the work.

已加上switch逻辑
RR lingu

(09-23-2020 12:14 PM)lingu Wrote: [ -> ]Also, design and implement the delete logic as we discussed -- for delete, rename the original file to be a different name, create a file in the original name and make sure it does not match any keywords.

Later, we need move the logic to a C++ program so that it can communicate with think in memory-to-memory data exchange.

删除逻辑设计在procone.py内，已在#49回复