Rigorous and Reliable (RAR)

(09-24-2020 01:05 PM)zhihao Wrote: [ -> ]BIBO系统目前部署在$bibo_base: /thinker/globe/soft/bibo

首文修改为
((BIBO系统目前部署在$bibo_base: /thinker/globe/soft/bibo
->
BIBO work environment 用于设置BIBO系统的运行环境
))

(09-24-2020 01:05 PM)zhihao Wrote: [ -> ]talk2thinker.sh

work() {
read $newcasepfn till meet blank line

Here backslash escape leads to trouble -- http://rar.shufangkeji.com:60380/showthr...3#pid43883

We should read the input without backslash escape interpretation -- 'read -r' instead of 'read'.

RR zhihao

--- working proactively, i've changed it in cod://bibo commit 6276848

(09-24-2020 01:05 PM)zhihao Wrote: [ -> ]select_case()
select_case() {
clear file $tspfn
$reqcaseid = requested case id
for each case; do

case is not defined. for $reqcaseid ?

do we support multiple case ids?

Quote: register tasks:

register tasks is too slow -- it is a file interface to sage. We are should sacli to send the request through a socket interface to Sage. I'll send out a review request.

(09-24-2020 01:05 PM)zhihao Wrote: [ -> ]

Code:

select_case()
[code]
select_case() {
    clear file $tspfn
    $reqcaseid = requested case id
    for each case; do
      register tasks:
        procone.py --tycano=$tycano --reqtype=$reqtype --reqcaseid=$reqcaseid
}

driver: task registration is too slow in wp289. We also need handle multiple concurrent queries so we should know a query ID (qid).

Proposal: I suggest we change the above three lines to

RR zhihao

(11-30-2020 03:22 PM)lingu Wrote: [ -> ]

(09-24-2020 01:05 PM)zhihao Wrote: [ -> ]

Code:

select_case()
[code]
select_case() {
    clear file $tspfn
    $reqcaseid = requested case id
    for each case; do
      register tasks:
        procone.py --tycano=$tycano --reqtype=$reqtype --reqcaseid=$reqcaseid
}

driver: task registration is too slow in wp289. We also need handle multiple concurrent queries so we should know a query ID (qid).

Proposal: I suggest we change the above three lines to

Code:

sacli --helper $bibo_helper match $newcasepfn
  if successful {
    qid=$(cat /tmp/bibo.qid)
  }

RR zhihao

where is sacli's D info? I don't know how to use it and can't find it. So I can't tell which 3 lines should be replaced.

update headopst:
BIBO use port 22,80,62818

(09-24-2020 01:05 PM)zhihao Wrote: [ -> ]insert_case()

Code:

insert_case() {
    create a new directory $newdir, set its name as $casecnt + 1

should be $casecnt++

$newdir is $bibo_share/procuratorate/tests

I suggest we rename it $bibo_share/procuratorate/cases and use a convar bibo_case_dir to refer to it.

RR zhihao

Quote: copy $newcasepfn to $newdir

The file becomes $newdir/content

Quote:delete_case()

Code:

delete_case() {
    clear file $tspfn
    $reqcaseid = requested case id
    for each case; do
        set option $tycano, $reqtype and $reqcaseid for procone.py
    done
    auntie register tasks
    generate delete success response
}

We should also handle $bibo_case_dir/content and I suggest we just use rid --insitu to rename it.

RR zhihao

(10-12-2020 01:36 AM)lingu Wrote: [ -> ]

(09-24-2020 01:05 PM)zhihao Wrote: [ -> ]talk2thinker.sh

work() {
read $newcasepfn till meet blank line

Here backslash escape leads to trouble -- http://rar.shufangkeji.com:60380/showthr...3#pid43883

We should read the input without backslash escape interpretation -- 'read -r' instead of 'read'.

RR zhihao

--- working proactively, i've changed it in cod://bibo commit 6276848

?

(11-30-2020 05:03 PM)zhihao Wrote: [ -> ]

(11-30-2020 03:22 PM)lingu Wrote: [ -> ]

(09-24-2020 01:05 PM)zhihao Wrote: [ -> ]

Code:

select_case()
[code]
select_case() {
    clear file $tspfn
    $reqcaseid = requested case id
    for each case; do
      register tasks:
        procone.py --tycano=$tycano --reqtype=$reqtype --reqcaseid=$reqcaseid
}

driver: task registration is too slow in wp289. We also need handle multiple concurrent queries so we should know a query ID (qid).

Proposal: I suggest we change the above three lines to

Code:

sacli --helper $bibo_helper match $newcasepfn
  if successful {
    qid=$(cat /tmp/bibo.qid)
  }

RR zhihao

where is sacli's D info? I don't know how to use it and can't find it. So I can't tell which 3 lines should be replaced.

"The above three lines" means the lines
-----
for each case; do
register tasks:
procone.py --tycano=$tycano --reqtype=$reqtype --reqcaseid=$reqcaseid
-----

I am sorry that sacli has little info. I think it evolved from sage-client. But we only have a bit info about sage-client like http://tab.d-thinker.org/showthread.php?...4#pid58644 That is bad info recording. I am creating a thread about sacli -- http://tab.d-thinker.org/showthread.php?tid=16959

(05-22-2021 11:22 AM)zhihao Wrote: [ -> ]update headopst:
BIBO use port 22,80,62818

How to make this info easy to find and use?